Bug 41784

Summary:

AX: when a node's role changes, the AX tree might need to be updated

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	bdakin: review+

chris fleizach

Reported 2010-07-07 12:03:22 PDT

if a role changes for a node, the AX tree might need to be updated because an element's ignored/not ignored status can change.

Attachments
Patch (4.56 KB, patch) 2010-07-07 12:07 PDT, chris fleizach	no flags	Details Formatted Diff Diff
Patch (5.09 KB, patch) 2010-07-07 13:24 PDT, chris fleizach	bdakin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

chris fleizach

Comment 1 2010-07-07 12:07:30 PDT

Created attachment 60762 [details] Patch

Beth Dakin

Comment 2 2010-07-07 12:48:36 PDT

Hey Chris! Is there any way to optimize this so that childrenChanged() is only called when necessary? It seems like it could be a costly operation if it is not needed.

chris fleizach

Comment 3 2010-07-07 12:54:09 PDT

i think we might be able to limit it to times when accessibilityIsIgnored status changes based on the role change

Beth Dakin

Comment 4 2010-07-07 12:57:36 PDT

That sounds good!

chris fleizach

Comment 5 2010-07-07 13:24:27 PDT

Created attachment 60771 [details] Patch

Beth Dakin

Comment 6 2010-07-07 13:25:10 PDT

Comment on attachment 60771 [details] Patch Yay!

chris fleizach

Comment 7 2010-07-07 13:26:58 PDT

http://trac.webkit.org/changeset/62694

Note You need to log in before you can comment on or make changes to this bug.