Bug 41782

Summary: Implement border-start and border-end properties
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: CSSAssignee: Erik Arvidsson <arv>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adele, bdakin, commit-queue, eric, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://dev.w3.org/csswg/css3-text-layout/
Attachments:
Description Flags
Patch
none
Patch none

Erik Arvidsson
Reported 2010-07-07 11:49:11 PDT
We currently support padding-start, margin-start and I'm committing support for padding-end and margin-end at the moment. The proposed CSS3 text layout module also provides: border-start-width border-start-style border-start-color border-start as well as the same for end.
Attachments
Patch (19.86 KB, patch)
2010-07-13 11:18 PDT, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Patch (19.97 KB, patch)
2010-07-13 11:30 PDT, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2010-07-13 11:18:02 PDT
Created attachment 61398 [details] Patch
WebKit Review Bot
Comment 2 2010-07-13 11:19:44 PDT
Attachment 61398 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/css/CSSParser.cpp:804: One space before end of line comments [whitespace/comments] [5] WebCore/css/CSSParser.cpp:810: One space before end of line comments [whitespace/comments] [5] WebCore/css/CSSParser.cpp:811: One space before end of line comments [whitespace/comments] [5] Total errors found: 3 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Erik Arvidsson
Comment 3 2010-07-13 11:30:22 PDT
Created attachment 61399 [details] Patch Fix style issues
WebKit Commit Bot
Comment 4 2010-07-14 12:02:12 PDT
Comment on attachment 61399 [details] Patch Clearing flags on attachment: 61399 Committed r63342: <http://trac.webkit.org/changeset/63342>
WebKit Commit Bot
Comment 5 2010-07-14 12:02:17 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-07-14 13:09:39 PDT
http://trac.webkit.org/changeset/63342 might have broken Chromium Mac Release The following changes are on the blame list: http://trac.webkit.org/changeset/63339 http://trac.webkit.org/changeset/63340 http://trac.webkit.org/changeset/63341 http://trac.webkit.org/changeset/63342
Note You need to log in before you can comment on or make changes to this bug.