Bug 41771

Summary: [V8] Document wrapper memory leak in bindings
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet, vitalyr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch.
none
Proposed patch. none

Pavel Podivilov
Reported 2010-07-07 08:50:44 PDT
[V8] Document wrapper memory leak in bindings Static persistent handle to shadowConstructor in V8HTMLDocument::WrapInShadowObject keeps the first context alive forever.
Attachments
Proposed patch. (2.33 KB, patch)
2010-07-07 09:02 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Proposed patch. (2.34 KB, patch)
2010-07-07 10:00 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2010-07-07 09:02:53 PDT
Created attachment 60740 [details] Proposed patch.
WebKit Review Bot
Comment 2 2010-07-07 09:03:35 PDT
Attachment 60740 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Vitaly Repeshko
Comment 3 2010-07-07 09:09:52 PDT
LG (with style errors fixed). Nate, could you please have a look and r+?
Nate Chapin
Comment 4 2010-07-07 09:15:26 PDT
Comment on attachment 60740 [details] Proposed patch. Ok, looks good (with the ChangeLog fixes, of course).
Pavel Podivilov
Comment 5 2010-07-07 10:00:25 PDT
Created attachment 60747 [details] Proposed patch.
Pavel Podivilov
Comment 6 2010-07-07 10:01:38 PDT
(In reply to comment #4) > (From update of attachment 60740 [details]) > Ok, looks good (with the ChangeLog fixes, of course). Fixed style, sorry for delay.
WebKit Commit Bot
Comment 7 2010-07-07 23:24:01 PDT
Comment on attachment 60747 [details] Proposed patch. Clearing flags on attachment: 60747 Committed r62763: <http://trac.webkit.org/changeset/62763>
WebKit Commit Bot
Comment 8 2010-07-07 23:24:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.