Bug 41771 - [V8] Document wrapper memory leak in bindings
Summary: [V8] Document wrapper memory leak in bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 08:50 PDT by Pavel Podivilov
Modified: 2010-07-07 23:24 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch. (2.33 KB, patch)
2010-07-07 09:02 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Proposed patch. (2.34 KB, patch)
2010-07-07 10:00 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-07-07 08:50:44 PDT 
[V8] Document wrapper memory leak in bindings

Static persistent handle to shadowConstructor in V8HTMLDocument::WrapInShadowObject keeps the first context alive forever.
Comment 1 Pavel Podivilov 2010-07-07 09:02:53 PDT 
Created attachment 60740 [details]
Proposed patch.
Comment 2 WebKit Review Bot 2010-07-07 09:03:35 PDT 
Attachment 60740 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Vitaly Repeshko 2010-07-07 09:09:52 PDT 
LG (with style errors fixed). Nate, could you please have a look and r+?
Comment 4 Nate Chapin 2010-07-07 09:15:26 PDT 
Comment on attachment 60740 [details]
Proposed patch.

Ok, looks good (with the ChangeLog fixes, of course).
Comment 5 Pavel Podivilov 2010-07-07 10:00:25 PDT 
Created attachment 60747 [details]
Proposed patch.
Comment 6 Pavel Podivilov 2010-07-07 10:01:38 PDT 
(In reply to comment #4)
> (From update of attachment 60740 [details])
> Ok, looks good (with the ChangeLog fixes, of course).

Fixed style, sorry for delay.
Comment 7 WebKit Commit Bot 2010-07-07 23:24:01 PDT 
Comment on attachment 60747 [details]
Proposed patch.

Clearing flags on attachment: 60747

Committed r62763: <http://trac.webkit.org/changeset/62763>
Comment 8 WebKit Commit Bot 2010-07-07 23:24:05 PDT 
All reviewed patches have been landed.  Closing bug.