Bug 41770

Summary: [EFL] Add API for dealing with cookies in EFL port.
Product: WebKit Reporter: Rafael Antognolli <antognolli+webkit>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barbieri, commit-queue, gyuyoung.kim, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch
commit-queue: commit-queue-
Patch none

Rafael Antognolli
Reported 2010-07-07 08:39:39 PDT
[EFL] Add API for dealing with cookies in EFL port.
Attachments
Patch (9.99 KB, patch)
2010-07-07 08:46 PDT, Rafael Antognolli 		no flags
DetailsFormatted DiffDiff
Patch (11.43 KB, patch)
2010-07-07 08:59 PDT, Rafael Antognolli 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch (11.02 KB, patch)
2010-07-13 11:40 PDT, Rafael Antognolli 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rafael Antognolli
Comment 1 2010-07-07 08:46:38 PDT
Created attachment 60737 [details] Patch
Rafael Antognolli
Comment 2 2010-07-07 08:59:21 PDT
Created attachment 60739 [details] Patch
Antonio Gomes
Comment 3 2010-07-13 11:16:22 PDT
Comment on attachment 60739 [details] Patch Good work! Note that the gtk guys preferred to just expose the current soup session through webkit_get_default_session(). That way, it delegates any manipulation/management to the application.
Rafael Antognolli
Comment 4 2010-07-13 11:40:55 PDT
Created attachment 61402 [details] Patch
WebKit Commit Bot
Comment 5 2010-07-13 11:42:12 PDT
Comment on attachment 60739 [details] Patch Rejecting patch 60739 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Parsed 5 diffs from patch file(s). patching file WebKit/CMakeListsEfl.txt Hunk #2 FAILED at 91. 1 out of 2 hunks FAILED -- saving rejects to file WebKit/CMakeListsEfl.txt.rej patching file WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKit/efl/ewk/EWebKit.h patching file WebKit/efl/ewk/ewk_cookies.cpp patching file WebKit/efl/ewk/ewk_cookies.h Full output: http://webkit-commit-queue.appspot.com/results/3528110
Antonio Gomes
Comment 6 2010-07-13 11:45:53 PDT
Comment on attachment 61402 [details] Patch Lets try again with this un-bitrotted new version
WebKit Commit Bot
Comment 7 2010-07-13 13:24:38 PDT
Comment on attachment 61402 [details] Patch Clearing flags on attachment: 61402 Committed r63241: <http://trac.webkit.org/changeset/63241>
WebKit Commit Bot
Comment 8 2010-07-13 13:24:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.