Summary: | Web Inspector: All RefPtr arguments and return values should be changed to PassRefPtr according to common practice. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Ilya Tikhonovsky <loislo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Ilya Tikhonovsky
2010-07-07 05:15:58 PDT
Created attachment 60720 [details]
[patch] initial version.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/CodeGeneratorInspector.pm M WebCore/inspector/InspectorTimelineAgent.cpp M WebCore/inspector/InspectorTimelineAgent.h M WebCore/inspector/TimelineRecordFactory.cpp M WebCore/inspector/TimelineRecordFactory.h Committed r62656 Thanks for doing this! Comment on attachment 60720 [details] [patch] initial version. > $typeTransform{"Object"} = { > - "param" => "const RefPtr<InspectorObject>&", > + "param" => "PassRefPtr<InspectorObject>", > $typeTransform{"Array"} = { > - "param" => "const RefPtr<InspectorArray>&", > + "param" => "PassRefPtr<InspectorArray>", This missed $typeTransform{"Value"}. Created attachment 60760 [details]
[PATCH] Fix for "Value" Type
Comment on attachment 60760 [details]
[PATCH] Fix for "Value" Type
Rubber-stamping on behalf of Ilya.
Comment on attachment 60760 [details] [PATCH] Fix for "Value" Type Landed the follow up in: Committed r62731 M WebCore/ChangeLog M WebCore/inspector/CodeGeneratorInspector.pm r62731 = d372bb126753aa13b5c79e95dcc4ea24c8a50992 (refs/remotes/trunk) http://trac.webkit.org/changeset/62731 |