Bug 41753

Summary:

[DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

New Bugs

Assignee:

Kent Tamura <tkent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, eric, hamaji, rolandsteiner, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	pfeldman: review+

Kent Tamura

Reported 2010-07-07 03:04:32 PDT

[DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions

Attachments
Patch (1.86 KB, patch) 2010-07-07 03:07 PDT, Kent Tamura	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kent Tamura

Comment 1 2010-07-07 03:07:10 PDT

Created attachment 60712 [details] Patch

Dimitri Glazkov (Google)

Comment 2 2010-07-07 08:36:02 PDT

Comment on attachment 60712 [details] Patch Sounds good, but please use notImplemented() :)

Kent Tamura

Comment 3 2010-07-07 18:40:50 PDT

(In reply to comment #2) > Sounds good, but please use notImplemented() :) Unfortunately, notImplemented() is a WebCore API. DRT should not use WebCore API directly.

Dimitri Glazkov (Google)

Comment 4 2010-07-07 18:47:31 PDT

(In reply to comment #3) > (In reply to comment #2) > > Sounds good, but please use notImplemented() :) > > Unfortunately, notImplemented() is a WebCore API. DRT should not use WebCore API directly. Doh! Then LGTM :)

Kent Tamura

Comment 5 2010-07-07 18:52:47 PDT

Landed as r62740

WebKit Review Bot

Comment 6 2010-07-07 19:15:32 PDT

http://trac.webkit.org/changeset/62740 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/62739 http://trac.webkit.org/changeset/62740

Note You need to log in before you can comment on or make changes to this bug.