Bug 41726

Summary: Expose URL matching from WebUserContentURLPattern
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: New BugsAssignee: Steve Falkenburg <sfalken>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch simon.fraser: review+

Steve Falkenburg
Reported 2010-07-06 17:55:56 PDT
Expose URL matching from WebUserContentURLPattern
Attachments
Patch (5.69 KB, patch)
2010-07-06 18:02 PDT, Steve Falkenburg 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Falkenburg
Comment 1 2010-07-06 18:02:36 PDT
Created attachment 60667 [details] Patch
Simon Fraser (smfr)
Comment 2 2010-07-06 22:22:46 PDT
Comment on attachment 60667 [details] Patch > Index: WebCore/ChangeLog > =================================================================== > + Expose URL matching from WebUserContentURLPattern > + https://bugs.webkit.org/show_bug.cgi?id=41726 > + > + No new tests. (OOPS!) You should remove this line. > Index: WebKit/mac/ChangeLog > =================================================================== > --- WebKit/mac/ChangeLog (revision 62607) > +++ WebKit/mac/ChangeLog (working copy) > @@ -1,3 +1,14 @@ > +2010-07-06 Steve Falkenburg <sfalken@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Expose URL matching from WebUserContentURLPattern > + https://bugs.webkit.org/show_bug.cgi?id=41726 > + > + * Misc/WebUserContentURLPattern.h: > + * Misc/WebUserContentURLPattern.mm: > + (-[WebUserContentURLPattern matchesURL:]): I would like to see a few words about the change. > Index: WebKit/win/ChangeLog > =================================================================== > + Expose URL matching from WebUserContentURLPattern > + https://bugs.webkit.org/show_bug.cgi?id=41726 > + > + * Interfaces/IWebUserContentURLPattern.idl: > + * Interfaces/IWebView.idl: > + * WebUserContentURLPattern.cpp: > + (WebUserContentURLPattern::matchesURL): > + * WebUserContentURLPattern.h: You could explain the whitespace change to the idl file here at least. r=me
Steve Falkenburg
Comment 3 2010-07-06 22:42:47 PDT
http://trac.webkit.org/changeset/62625
Note You need to log in before you can comment on or make changes to this bug.