Bug 41719

Summary: Add PluginInfoStore::findPlugin
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2010-07-06 15:38:02 PDT
Add PluginInfoStore::findPlugin
Attachments
Patch (7.35 KB, patch)
2010-07-06 15:39 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-07-06 15:39:41 PDT
Created attachment 60657 [details] Patch
WebKit Review Bot
Comment 2 2010-07-06 15:42:14 PDT
Attachment 60657 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit2/UIProcess/Plugins/PluginInfoStore.cpp:29: Alphabetical sorting problem. [build/include_order] [4] WebKit2/UIProcess/Plugins/PluginInfoStore.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Rowe (bdash)
Comment 3 2010-07-07 00:49:40 PDT
Did this get landed or am I imagining things?
Anders Carlsson
Comment 4 2010-07-07 10:04:20 PDT
Yup, fixed in http://trac.webkit.org/projects/webkit/changeset/62600.
Note You need to log in before you can comment on or make changes to this bug.