Bug 41719 - Add PluginInfoStore::findPlugin
Summary: Add PluginInfoStore::findPlugin
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
Depends on:
Reported: 2010-07-06 15:38 PDT by Anders Carlsson
Modified: 2010-07-07 10:04 PDT (History)
1 user (show)

See Also:

Patch (7.35 KB, patch)
2010-07-06 15:39 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-06 15:38:02 PDT
Add PluginInfoStore::findPlugin
Comment 1 Anders Carlsson 2010-07-06 15:39:41 PDT
Created attachment 60657 [details]
Comment 2 WebKit Review Bot 2010-07-06 15:42:14 PDT
Attachment 60657 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/Plugins/PluginInfoStore.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/Plugins/PluginInfoStore.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 4 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Rowe (bdash) 2010-07-07 00:49:40 PDT
Did this get landed or am I imagining things?
Comment 4 Anders Carlsson 2010-07-07 10:04:20 PDT
Yup, fixed in http://trac.webkit.org/projects/webkit/changeset/62600.