Bug 41709

Summary: DOM plug-in related renames
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Anders Carlsson
Reported 2010-07-06 11:24:01 PDT
DOM plug-in related renames
Attachments
Patch (70.78 KB, patch)
2010-07-06 11:26 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (72.22 KB, patch)
2010-07-06 11:50 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-07-06 11:26:51 PDT
Created attachment 60646 [details] Patch
WebKit Review Bot
Comment 2 2010-07-06 11:28:46 PDT
Attachment 60646 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/page/Navigator.h:30: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2010-07-06 11:36:18 PDT
Attachment 60646 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/3369370
Sam Weinig
Comment 4 2010-07-06 11:42:58 PDT
Comment on attachment 60646 [details] Patch I like the renames, but this is going to break tests.
Anders Carlsson
Comment 5 2010-07-06 11:50:27 PDT
Created attachment 60649 [details] Patch
WebKit Review Bot
Comment 6 2010-07-06 11:52:51 PDT
Attachment 60649 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/page/Navigator.h:30: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 7 2010-07-06 12:28:38 PDT
http://trac.webkit.org/changeset/62577 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release
Anders Carlsson
Comment 8 2010-07-14 11:32:01 PDT
Committed r62577: <http://trac.webkit.org/changeset/62577>
Note You need to log in before you can comment on or make changes to this bug.