Summary: | DeviceOrientationEventConstructor should be exposed at window.DeviceOrientationEvent | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Steve Block <steveblock> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hans, jorlow, steveblock | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 30335 | ||||||
Attachments: |
|
Description
Steve Block
2010-07-06 03:58:32 PDT
Created attachment 60616 [details]
Patch
Comment on attachment 60616 [details]
Patch
The code looks right. A couple questions about the tests.
LayoutTests/fast/dom/Window/window-properties-device-orientation.html:34
+ if (typeof value == "object" && value == null) //;
Why "//;" here?
LayoutTests/fast/dom/Window/window-properties.html:86
+ "window.DeviceOrientationEvent" : 1,
Why skip this?
> LayoutTests/fast/dom/Window/window-properties-device-orientation.html:34 > + if (typeof value == "object" && value == null) //; > Why "//;" here? No reason. This was copied from window-properties.html. Will remove before landing. > LayoutTests/fast/dom/Window/window-properties.html:86 > + "window.DeviceOrientationEvent" : 1, > Why skip this? DeviceOrientation isn't enabled on all platforms, so we don't test it here, but instead test it in window-properties-device-orientation.html, which platforms can choose to skip. Committed r62653: <http://trac.webkit.org/changeset/62653> |