Bug 41685

Summary:

DeviceOrientationEventConstructor should be exposed at window.DeviceOrientationEvent

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hans, jorlow, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

30335

Attachments:

Description	Flags
Patch	abarth: review+, abarth: commit-queue-

Steve Block

Reported 2010-07-06 03:58:32 PDT

This matches other event types.

Attachments
Patch (16.41 KB, patch) 2010-07-06 04:08 PDT, Steve Block	abarth: review+ abarth: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2010-07-06 04:08:04 PDT

Created attachment 60616 [details] Patch

Adam Barth

Comment 2 2010-07-07 03:16:28 PDT

Comment on attachment 60616 [details] Patch The code looks right. A couple questions about the tests. LayoutTests/fast/dom/Window/window-properties-device-orientation.html:34 + if (typeof value == "object" && value == null) //; Why "//;" here? LayoutTests/fast/dom/Window/window-properties.html:86 + "window.DeviceOrientationEvent" : 1, Why skip this?

Steve Block

Comment 3 2010-07-07 04:24:27 PDT

> LayoutTests/fast/dom/Window/window-properties-device-orientation.html:34 > + if (typeof value == "object" && value == null) //; > Why "//;" here? No reason. This was copied from window-properties.html. Will remove before landing. > LayoutTests/fast/dom/Window/window-properties.html:86 > + "window.DeviceOrientationEvent" : 1, > Why skip this? DeviceOrientation isn't enabled on all platforms, so we don't test it here, but instead test it in window-properties-device-orientation.html, which platforms can choose to skip.

Steve Block

Comment 4 2010-07-07 04:52:29 PDT

Committed r62653: <http://trac.webkit.org/changeset/62653>

Note You need to log in before you can comment on or make changes to this bug.