Bug 41679

Summary: [Qt] REGRESSION (r62511): 64-bit build is broken
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: barraclough, loki, sam, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Bug Depends on:    
Bug Blocks: 41641    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2010-07-06 03:15:14 PDT
They don't exist on Linux: #include <mach/mach_init.h> #include <mach/vm_map.h> arc4random() function is available only on bsd based systems by default. On Linux, you have to install libbsd-dev package to use arc4random(). I think it isn't a good idea to add a new dependency because of this function.
Attachments
Patch (1.86 KB, patch)
2010-07-06 03:35 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2010-07-06 03:35:00 PDT
Created attachment 60611 [details] Patch
Gabor Loki
Comment 2 2010-07-06 04:15:29 PDT
And what about QtWebKit on MAC? It satisfy both requirements - the includes and the arc4random function. (I guess the original change was induced by a bug or a limitation on Mac. In additional this patch will not fix the Gtk-64 which will have the same error (if the current include problem is fixed).
Adam Barth
Comment 3 2010-07-07 03:22:43 PDT
Comment on attachment 60611 [details] Patch I'm all for build fixes, but the second part of your diff looks like a bit of copy/paste. Is there a better way of structuring the #ifdefs to just target the arc4random part?
Csaba Osztrogonác
Comment 4 2010-07-07 03:33:28 PDT
Comment on attachment 60611 [details] Patch This fix is obsolete, because the original patch was rolled-out. Gavin, could you fix this issue too when you land the fixed patch in https://bugs.webkit.org/show_bug.cgi?id=41641 ?
Gavin Barraclough
Comment 5 2010-07-08 11:55:22 PDT
Resolved (hopefully) as a part of relanding initial patch. *** This bug has been marked as a duplicate of bug 41641 ***
Note You need to log in before you can comment on or make changes to this bug.