Bug 41612

Summary:

REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, cjerdonek, dbates, ukai

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Linux

Bug Depends on:

Bug Blocks:

39058

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2010-07-05 07:08:49 PDT

Now WebKitTools/Scripts/ensure-valid-python generates one more 
/tmp/XXXXXXXX file again and again on my linux machine.

I propose the following change:
-my $tempDirectory = File::Temp->tempdir("WebKitPythonXXXX");
+my $tempDirectory = File::Temp::tempdir("WebKitPythonXXXX", TMPDIR => 1, CLEANUP => 1);

Comment 1 Csaba Osztrogonác 2010-07-05 07:13:01 PDT

Created attachment 60527 [details]
Patch

Comment 2 Fumitoshi Ukai 2010-07-05 18:19:32 PDT

Comment on attachment 60527 [details]
Patch

LGTM

Comment 3 Eric Seidel (no email) 2010-07-05 23:15:56 PDT

I don't really know what this does.

Comment 4 Csaba Osztrogonác 2010-07-05 23:29:18 PDT

Comment on attachment 60527 [details]
Patch

Clearing flags on attachment: 60527

Committed r62526: <http://trac.webkit.org/changeset/62526>

Comment 5 Csaba Osztrogonác 2010-07-05 23:29:26 PDT

All reviewed patches have been landed.  Closing bug.