Bug 41593

Summary: new-run-webkit-tests does not use port specific environment
Product: WebKit Reporter: Gabor Rapcsanyi <rgabor>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cjerdonek, commit-queue, dbates, dpranke, eric, ojan, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch
none
proposed_patch_v2
eric: review-
proposed_patch_v3 none

Gabor Rapcsanyi
Reported 2010-07-05 01:41:39 PDT
Created attachment 60502 [details] proposed patch Pass port specific environment to server process to be able to run new-run-webkit-tests on Qt port.
Attachments
proposed patch (2.13 KB, patch)
2010-07-05 01:41 PDT, Gabor Rapcsanyi 		no flags
DetailsFormatted DiffDiff
proposed_patch_v2 (2.16 KB, patch)
2010-07-05 02:04 PDT, Gabor Rapcsanyi 		eric: review-
DetailsFormatted DiffDiff
proposed_patch_v3 (2.36 KB, patch)
2010-07-06 05:13 PDT, Gabor Rapcsanyi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2010-07-05 01:42:14 PDT
Attachment 60502 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/Scripts/webkitpy/layout_tests/port/qt.py:97: no newline at end of file [pep8/W292] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gabor Rapcsanyi
Comment 2 2010-07-05 02:04:31 PDT
Created attachment 60505 [details] proposed_patch_v2 fixed style
Eric Seidel (no email)
Comment 3 2010-07-06 02:04:14 PDT
Comment on attachment 60505 [details] proposed_patch_v2 This should copy the environment. See ChromiumPort does something similar.
Gabor Rapcsanyi
Comment 4 2010-07-06 05:13:18 PDT
Created attachment 60621 [details] proposed_patch_v3 Now, the port specific environment is taken from the base class like in Chromium.
Eric Seidel (no email)
Comment 5 2010-07-07 01:10:36 PDT
Comment on attachment 60621 [details] proposed_patch_v3 OK.
WebKit Commit Bot
Comment 6 2010-07-07 01:38:23 PDT
Comment on attachment 60621 [details] proposed_patch_v3 Clearing flags on attachment: 60621 Committed r62635: <http://trac.webkit.org/changeset/62635>
WebKit Commit Bot
Comment 7 2010-07-07 01:38:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.