| Summary: | new-run-webkit-tests does not use port specific environment | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gabor Rapcsanyi <rgabor> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abecsi, cjerdonek, commit-queue, dbates, dpranke, eric, ojan, ossy, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Attachment 60502 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/Scripts/webkitpy/layout_tests/port/qt.py:97: no newline at end of file [pep8/W292] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 60505 [details]
proposed_patch_v2
fixed style
Comment on attachment 60505 [details]
proposed_patch_v2
This should copy the environment. See ChromiumPort does something similar.
Created attachment 60621 [details]
proposed_patch_v3
Now, the port specific environment is taken from the base class like in Chromium.
Comment on attachment 60621 [details]
proposed_patch_v3
OK.
Comment on attachment 60621 [details] proposed_patch_v3 Clearing flags on attachment: 60621 Committed r62635: <http://trac.webkit.org/changeset/62635> All reviewed patches have been landed. Closing bug. |
Created attachment 60502 [details] proposed patch Pass port specific environment to server process to be able to run new-run-webkit-tests on Qt port.