Bug 41593 - new-run-webkit-tests does not use port specific environment
Summary: new-run-webkit-tests does not use port specific environment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-05 01:41 PDT by Gabor Rapcsanyi
Modified: 2010-07-07 01:38 PDT (History)
9 users (show)

See Also:

Attachments
proposed patch (2.13 KB, patch)
2010-07-05 01:41 PDT, Gabor Rapcsanyi 		no flags Details | Formatted Diff | Diff
proposed_patch_v2 (2.16 KB, patch)
2010-07-05 02:04 PDT, Gabor Rapcsanyi 		eric: review-
Details | Formatted Diff | Diff
proposed_patch_v3 (2.36 KB, patch)
2010-07-06 05:13 PDT, Gabor Rapcsanyi 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Rapcsanyi 2010-07-05 01:41:39 PDT 
Created attachment 60502 [details]
proposed patch

Pass port specific environment to server process to be able to run new-run-webkit-tests on Qt port.
Comment 1 WebKit Review Bot 2010-07-05 01:42:14 PDT 
Attachment 60502 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/Scripts/webkitpy/layout_tests/port/qt.py:97:  no newline at end of file  [pep8/W292] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Gabor Rapcsanyi 2010-07-05 02:04:31 PDT 
Created attachment 60505 [details]
proposed_patch_v2

fixed style
Comment 3 Eric Seidel (no email) 2010-07-06 02:04:14 PDT 
Comment on attachment 60505 [details]
proposed_patch_v2

This should copy the environment.  See ChromiumPort does something similar.
Comment 4 Gabor Rapcsanyi 2010-07-06 05:13:18 PDT 
Created attachment 60621 [details]
proposed_patch_v3

Now, the port specific environment is taken from the base class like in Chromium.
Comment 5 Eric Seidel (no email) 2010-07-07 01:10:36 PDT 
Comment on attachment 60621 [details]
proposed_patch_v3

OK.
Comment 6 WebKit Commit Bot 2010-07-07 01:38:23 PDT 
Comment on attachment 60621 [details]
proposed_patch_v3

Clearing flags on attachment: 60621

Committed r62635: <http://trac.webkit.org/changeset/62635>
Comment 7 WebKit Commit Bot 2010-07-07 01:38:28 PDT 
All reviewed patches have been landed.  Closing bug.