Bug 41582

Summary: Finish implementning "any other end tag" for "in body" mode
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch
none
now with more tests
none
Patch none

Eric Seidel (no email)
Reported 2010-07-04 13:18:34 PDT
Finish implementning "any other end tag" for "in body" mode
Attachments
Patch (4.94 KB, patch)
2010-07-04 13:26 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
now with more tests (5.98 KB, patch)
2010-07-04 15:34 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (6.80 KB, patch)
2010-07-05 11:11 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-07-04 13:26:49 PDT
Created attachment 60476 [details] Patch
Adam Barth
Comment 2 2010-07-04 13:33:51 PDT
Comment on attachment 60476 [details] Patch Can you write some more tests for this code? The one result isn't really enough to cover all the logic you're adding.
Eric Seidel (no email)
Comment 3 2010-07-04 15:34:23 PDT
Created attachment 60484 [details] now with more tests
Adam Barth
Comment 4 2010-07-04 21:31:39 PDT
Comment on attachment 60484 [details] now with more tests You need to svn add inbody01.dat :)
Eric Seidel (no email)
Comment 5 2010-07-05 11:11:16 PDT
Created attachment 60556 [details] Patch
Adam Barth
Comment 6 2010-07-05 11:26:34 PDT
Comment on attachment 60556 [details] Patch Thanks.
WebKit Commit Bot
Comment 7 2010-07-05 12:03:29 PDT
Comment on attachment 60556 [details] Patch Rejecting patch 60556 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: ing Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found Testing 19289 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14194 tests run. 245.30s total testing time 14193 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/3370339
Eric Seidel (no email)
Comment 8 2010-07-05 12:07:46 PDT
Comment on attachment 60556 [details] Patch worst time for a flaky test ever.
WebKit Commit Bot
Comment 9 2010-07-05 12:42:14 PDT
Comment on attachment 60556 [details] Patch Clearing flags on attachment: 60556 Committed r62498: <http://trac.webkit.org/changeset/62498>
WebKit Commit Bot
Comment 10 2010-07-05 12:42:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.