Summary: | Finish implementning "any other end tag" for "in body" mode | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, commit-queue | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | OS X 10.5 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 41123 | ||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2010-07-04 13:18:34 PDT
Created attachment 60476 [details]
Patch
Comment on attachment 60476 [details]
Patch
Can you write some more tests for this code? The one result isn't really enough to cover all the logic you're adding.
Created attachment 60484 [details]
now with more tests
Comment on attachment 60484 [details]
now with more tests
You need to svn add inbody01.dat :)
Created attachment 60556 [details]
Patch
Comment on attachment 60556 [details]
Patch
Thanks.
Comment on attachment 60556 [details] Patch Rejecting patch 60556 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: ing Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found Testing 19289 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14194 tests run. 245.30s total testing time 14193 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/3370339 Comment on attachment 60556 [details]
Patch
worst time for a flaky test ever.
Comment on attachment 60556 [details] Patch Clearing flags on attachment: 60556 Committed r62498: <http://trac.webkit.org/changeset/62498> All reviewed patches have been landed. Closing bug. |