Bug 41582

Summary: Finish implementning "any other end tag" for "in body" mode
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch
none
now with more tests
none
Patch none

Description Eric Seidel (no email) 2010-07-04 13:18:34 PDT
Finish implementning "any other end tag" for "in body" mode
Comment 1 Eric Seidel (no email) 2010-07-04 13:26:49 PDT
Created attachment 60476 [details]
Patch
Comment 2 Adam Barth 2010-07-04 13:33:51 PDT
Comment on attachment 60476 [details]
Patch

Can you write some more tests for this code?  The one result isn't really enough to cover all the logic you're adding.
Comment 3 Eric Seidel (no email) 2010-07-04 15:34:23 PDT
Created attachment 60484 [details]
now with more tests
Comment 4 Adam Barth 2010-07-04 21:31:39 PDT
Comment on attachment 60484 [details]
now with more tests

You need to svn add inbody01.dat :)
Comment 5 Eric Seidel (no email) 2010-07-05 11:11:16 PDT
Created attachment 60556 [details]
Patch
Comment 6 Adam Barth 2010-07-05 11:26:34 PDT
Comment on attachment 60556 [details]
Patch

Thanks.
Comment 7 WebKit Commit Bot 2010-07-05 12:03:29 PDT
Comment on attachment 60556 [details]
Patch

Rejecting patch 60556 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Last 500 characters of output:
ing Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found
Testing 19289 test cases.
fast/loader/recursive-before-unload-crash.html -> failed

Exiting early after 1 failures. 14194 tests run.
245.30s total testing time

14193 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/3370339
Comment 8 Eric Seidel (no email) 2010-07-05 12:07:46 PDT
Comment on attachment 60556 [details]
Patch

worst time for a flaky test ever.
Comment 9 WebKit Commit Bot 2010-07-05 12:42:14 PDT
Comment on attachment 60556 [details]
Patch

Clearing flags on attachment: 60556

Committed r62498: <http://trac.webkit.org/changeset/62498>
Comment 10 WebKit Commit Bot 2010-07-05 12:42:18 PDT
All reviewed patches have been landed.  Closing bug.