Bug 41565

Summary: Repatching in ARMv7Assembler::repatchLoadPtrToLEA is broken
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch oliver: review+

Gavin Barraclough
Reported 2010-07-02 23:31:08 PDT
This method tried to repatch a LDR (T2) into an ADD (T3) – but it only repatches the first instruction word. The layout of the fields in the second word is different, and also needs repatching.
Attachments
The patch (1.76 KB, patch)
2010-07-02 23:33 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-07-02 23:33:25 PDT
Created attachment 60441 [details] The patch
WebKit Review Bot
Comment 2 2010-07-02 23:36:27 PDT
Attachment 60441 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/assembler/ARMv7Assembler.h:1733: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3 2010-07-02 23:36:55 PDT
Comment on attachment 60441 [details] The patch > + This method tried to repatch a LDR (T2) into an ADD (T3) â but it only â? otherwise r=me
Gavin Barraclough
Comment 4 2010-07-02 23:46:04 PDT
Fixed in r62437.
Note You need to log in before you can comment on or make changes to this bug.