Bug 41540

Summary: WebKit2: Add InjectedCode API to get a list of subframes
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch andersca: review+

Sam Weinig
Reported 2010-07-02 14:21:22 PDT
Add InjectedCode API to get a list of subframes.
Attachments
Patch (4.31 KB, patch)
2010-07-02 14:30 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-07-02 14:30:12 PDT
Created attachment 60403 [details] Patch
WebKit Review Bot
Comment 2 2010-07-02 14:33:25 PDT
Attachment 60403 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit2/WebProcess/WebPage/WebFrame.cpp:187: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3 2010-07-02 14:40:54 PDT
Comment on attachment 60403 [details] Patch > + for (Frame* child = m_coreFrame->tree()->firstChild(); child; child = child->tree()->nextSibling(), ++i) { > + WebFrame* webFrame = static_cast<WebFrameLoaderClient*>(child->loader()->client())->webFrame(); tab!!!! :-O Remove this and r=me
Sam Weinig
Comment 4 2010-07-02 16:01:48 PDT
Fixed in http://trac.webkit.org/changeset/62406.
Note You need to log in before you can comment on or make changes to this bug.