| Summary: | Some http tests fail on Windows with Cygwin 1.7 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Weinstein <bweinstein> | ||||
| Component: | Tools / Tests | Assignee: | Brian Weinstein <bweinstein> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Attachments: |
|
||||||
Created attachment 60399 [details]
[PATCH] Fix
Attachment 60399 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:620: Tab found; better to use spaces [whitespace/tab] [1]
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:621: Tab found; better to use spaces [whitespace/tab] [1]
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:622: Tab found; better to use spaces [whitespace/tab] [1]
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:623: Tab found; better to use spaces [whitespace/tab] [1]
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:624: Tab found; better to use spaces [whitespace/tab] [1]
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:625: Tab found; better to use spaces [whitespace/tab] [1]
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:626: Tab found; better to use spaces [whitespace/tab] [1]
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:627: Tab found; better to use spaces [whitespace/tab] [1]
Total errors found: 8 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|
Some http tests fail on Windows with Cygwin 1.7, because LayoutTestControllerWin::resolveCygwinPath fails, because: DWORD result = ::SHGetValueW(HKEY_LOCAL_MACHINE, TEXT("SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/"), TEXT("native"), &keyType, &rootPath, &rootPathSize); fails, due to a configuration change on Cygwin 1.7