| Summary: | [BREWMP] Change the CRASH() macro to print "WebKit CRASH" log. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kwang Yul Seo <skyul> | ||||
| Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | beergun, commit-queue, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | Other | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 33564 | ||||||
| Attachments: |
|
||||||
|
Description
Kwang Yul Seo
2010-07-02 11:03:59 PDT
Created attachment 60381 [details]
Patch
Attachment 60381 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
JavaScriptCore/wtf/Assertions.h:175: Missing space before ( in while( [whitespace/parens] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 60381 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 > JavaScriptCore/wtf/Assertions.h:175: Missing space before ( in while( [whitespace/parens] [5] > Total errors found: 1 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. The patch did not pass style-queue, but actually it is consistent with other CRASH macros. Comment on attachment 60381 [details] Patch Clearing flags on attachment: 60381 Committed r62441: <http://trac.webkit.org/changeset/62441> All reviewed patches have been landed. Closing bug. |