Bug 41524

Summary: [BREWMP] Change the CRASH() macro to print "WebKit CRASH" log.
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beergun, commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Patch none

Kwang Yul Seo
Reported 2010-07-02 11:03:59 PDT
Print "WebKit CRASH" before crashing.
Attachments
Patch (1.42 KB, patch)
2010-07-02 11:05 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-07-02 11:05:35 PDT
Created attachment 60381 [details] Patch
WebKit Review Bot
Comment 2 2010-07-02 11:06:18 PDT
Attachment 60381 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/wtf/Assertions.h:175: Missing space before ( in while( [whitespace/parens] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kwang Yul Seo
Comment 3 2010-07-02 11:08:27 PDT
(In reply to comment #2) > Attachment 60381 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 > JavaScriptCore/wtf/Assertions.h:175: Missing space before ( in while( [whitespace/parens] [5] > Total errors found: 1 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. The patch did not pass style-queue, but actually it is consistent with other CRASH macros.
WebKit Commit Bot
Comment 4 2010-07-03 01:17:49 PDT
Comment on attachment 60381 [details] Patch Clearing flags on attachment: 60381 Committed r62441: <http://trac.webkit.org/changeset/62441>
WebKit Commit Bot
Comment 5 2010-07-03 01:17:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.