|Summary:||JavaInstanceV8 needs to push a local reference frame to avoid table overflow.|
|Product:||WebKit||Reporter:||Steve Block <steveblock>|
|Component:||WebCore Misc.||Assignee:||Nobody <webkit-unassigned>|
|Version:||528+ (Nightly build)|
Description Steve Block 2010-07-02 03:34:21 PDT
Similar to jsc's implementation, this is needed to restrict the amount of local references in a given jni frame. Once the frame is popped from the stack, all local references are cleaned.
Comment 2 Patrick 2010-07-02 05:44:37 PDT
Should the LOGV be removed from JavaInstanceV8.cpp as well?
Comment 4 Adam Barth 2010-07-07 02:39:48 PDT
Comment on attachment 60364 [details] Patch This change is taxing the boundaries of my understanding of Java. Ideally, the ChangeLog would contain more information to help folks understand what problem is being solved and how this patch goes about solving them. I'm hesitating to R+ this change, but on balance, it seems like the right thing to do. WebCore/ChangeLog:8 + No new tests. sad face WebCore/bridge/jni/v8/JavaInstanceV8.cpp:50 + #define NUM_LOCAL_REFS 64 Where does this number come from?