Bug 41513

Summary: [WinCairo] Disable QT private player if GStreamer is enabled
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, eric.carlson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
MediaPlayer: disable QT player on WinCairo none

Philippe Normand
Reported 2010-07-02 01:58:40 PDT
It doesn't make much sense to build the QT player for WinCairo if the GStreamer player is enabled already. QuickTime is not part of the current requirements but GStreamer should soon be added.
Attachments
MediaPlayer: disable QT player on WinCairo (2.03 KB, patch)
2010-07-02 02:01 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-07-02 02:01:35 PDT
Created attachment 60352 [details] MediaPlayer: disable QT player on WinCairo
Eric Carlson
Comment 2 2010-07-18 10:15:14 PDT
(In reply to comment #0) > It doesn't make much sense to build the QT player for WinCairo if the GStreamer player is > enabled already. QuickTime is not part of the current requirements but GStreamer should > soon be added. On the other hand, the QuickTime media engine does nothing unless the use has QuickTime installed and MediaPlayer supports having support for more than one media engine, so is there any harm in allowing someone to build in support for both QuickTime and GStreamer?
Philippe Normand
Comment 3 2010-07-18 10:32:41 PDT
(In reply to comment #2) > (In reply to comment #0) > > It doesn't make much sense to build the QT player for WinCairo if the GStreamer player is > > enabled already. QuickTime is not part of the current requirements but GStreamer should > > soon be added. > > On the other hand, the QuickTime media engine does nothing unless the use has QuickTime installed and MediaPlayer supports having support for more than one media engine, so is there any harm in allowing someone to build in support for both QuickTime and GStreamer? Agreed it should be possible indeed. But because the current WinCairo requirements don't include QuickTime, the private mediaplayer doesn't build at all. So to be able to include the MediaPlayer.cpp file in the WinCairo build I had to make that patch :(
Philippe Normand
Comment 4 2010-07-18 11:26:41 PDT
Ok I can probably provide a more explicit patch than this using PLATFORM(CAIRO) instead of USE(GSTREAMER)
Martin Robinson
Comment 5 2010-08-17 12:57:25 PDT
Comment on attachment 60352 [details] MediaPlayer: disable QT player on WinCairo Sounds like you are working on another version of this patch? I've cleared the review flag until you post it. If this is indeed your final version, feel free to reflag it!
Philippe Normand
Comment 6 2014-03-03 00:16:39 PST
GStreamer has been enabled in WinCairo some time ago.
Note You need to log in before you can comment on or make changes to this bug.