Bug 41489 – Make process launching asynchronous

• Component: WebKit2
• Status: RESOLVED FIXED

[Anders Carlsson]

Make process launching asynchronous

[Anders Carlsson]

Created attachment 60294 [details]
Patch

[WebKit Review Bot]

Attachment 60294 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/Launcher/win/ProcessLauncherWin.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/Launcher/ProcessLauncher.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 60294 [details]
Patch

> +    // Register ourselves.
> +    kern_return_t kr = bootstrap_register2(bootstrap_port, (char*)"com.apple.WebKit.WebProcess", listeningPort, /* BOOTSTRAP_PER_PID_SERVICE */ 1);
> +    if (kr)
> +        NSLog(@"bootstrap_register2 result: %x", kr);
> +    
> +    pid_t processIdentifier;
> +    int result = posix_spawn(&processIdentifier, path, 0, 0, (char *const*)args, *_NSGetEnviron());
> +    if (result)
> +        NSLog(@"posix_spawn result: %d", result);

Not a new issue but, should we bail on errors here?

r=me.

[Anders Carlsson]

Committed r62305: <http://trac.webkit.org/changeset/62305>