Bug 41479

Summary: Change the CoreIPC connection identifier to be a HANDLE on Windows
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mitz: review+

Anders Carlsson
Reported 2010-07-01 12:31:36 PDT
Change the CoreIPC connection identifier to be a HANDLE on Windows
Attachments
Patch (13.52 KB, patch)
2010-07-01 12:36 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-07-01 12:36:59 PDT
Created attachment 60273 [details] Patch
WebKit Review Bot
Comment 2 2010-07-01 12:39:25 PDT
Attachment 60273 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit2/WebProcess/win/WebProcessMain.cpp:31: Alphabetical sorting problem. [build/include_order] [4] WebKit2/WebProcess/win/WebProcessMain.cpp:64: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2010-07-01 13:04:37 PDT
Committed r62290: <http://trac.webkit.org/changeset/62290>
Note You need to log in before you can comment on or make changes to this bug.