Bug 41463

Summary: [GTK] Stop using GdkRegion in 3.x mode
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
gdkregion.diff
none
gdkregion.diff
none
gdkregion.diff none

Xan Lopez
Reported 2010-07-01 07:17:17 PDT
GdkRegion was completely removed in GTK+ 3.x, and GdkRectangle just made an alias for a cairo rectangle. This patch moves us unconditionally to cairo_region_t when possible, and when that's not possible (because there's interaction with GTK+), creates a branch using the cairo API.
Attachments
gdkregion.diff (12.33 KB, patch)
2010-07-01 07:19 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
gdkregion.diff (12.67 KB, patch)
2010-07-01 13:53 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
gdkregion.diff (12.72 KB, patch)
2010-07-01 14:23 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2010-07-01 07:19:36 PDT
Created attachment 60245 [details] gdkregion.diff
WebKit Review Bot
Comment 2 2010-07-01 07:20:32 PDT
Attachment 60245 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/graphics/IntRect.h:54: cairo_rectangle_int_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/gtk/RenderThemeGtk.h:40: cairo_rectangle_int_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/gtk/FontGtk.cpp:187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/platform/graphics/gtk/FontGtk.cpp:187: n_rects is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/gtk/FontGtk.cpp:188: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/platform/graphics/gtk/FontGtk.cpp:189: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/platform/graphics/gtk/FontGtk.cpp:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/platform/graphics/gtk/FontGtk.cpp:221: Use 0 instead of NULL. [readability/null] [5] Total errors found: 8 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Xan Lopez
Comment 3 2010-07-01 13:53:11 PDT
Created attachment 60282 [details] gdkregion.diff This version does not unify some code paths, so that we don't have to depend on a pretty new cairo version.
WebKit Review Bot
Comment 4 2010-07-01 13:55:36 PDT
Attachment 60282 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/graphics/IntRect.h:54: cairo_rectangle_int_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/gtk/RenderThemeGtk.h:40: cairo_rectangle_int_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/gtk/FontGtk.cpp:188: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/platform/graphics/gtk/FontGtk.cpp:188: n_rects is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/gtk/FontGtk.cpp:189: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/platform/graphics/gtk/FontGtk.cpp:190: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/platform/graphics/gtk/FontGtk.cpp:192: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/platform/graphics/gtk/FontGtk.cpp:226: Use 0 instead of NULL. [readability/null] [5] Total errors found: 8 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Xan Lopez
Comment 5 2010-07-01 14:23:38 PDT
Created attachment 60286 [details] gdkregion.diff Third time is the charm. I'm not friends with EWS anymore.
WebKit Review Bot
Comment 6 2010-07-01 14:25:41 PDT
Attachment 60286 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/graphics/IntRect.h:54: cairo_rectangle_int_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/gtk/RenderThemeGtk.h:40: cairo_rectangle_int_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/gtk/FontGtk.cpp:185: cairo_region_shrink is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 3 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gustavo Noronha (kov)
Comment 7 2010-07-01 16:33:45 PDT
Comment on attachment 60286 [details] gdkregion.diff WebCore/platform/graphics/gtk/FontGtk.cpp:188 + /* clear region */ Fix this to be a real WebKit comment ;D You are on your way to destruction, make your time.
Xan Lopez
Comment 8 2010-07-01 16:58:39 PDT
Comment on attachment 60286 [details] gdkregion.diff Landed in r62329.
Xan Lopez
Comment 9 2010-07-01 16:58:50 PDT
Kabloom.
Note You need to log in before you can comment on or make changes to this bug.