Bug 41457

Summary:

[Qt] Dragging within webkit with a drag created via Javascript ends up misinterpreting the data

Product:

WebKit

Reporter:

andy.shaw

Component:

WebCore Misc.

Assignee:

QtWebKit Unassigned <webkit-qt-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, kling

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Example HTML reproducing the problem	none
Propsoed patch	none
Proposed patch (trunk)	kling: review-
Proposed patch v2	none

andy.shaw

Reported 2010-07-01 05:15:22 PDT

Created attachment 60222 [details] Example HTML reproducing the problem Dragging within webkit with a drag created via Javascript ends up misinterpreting the data, in the example attached if you drag from the drag area to the drop area then you will see that the data looks like it has been converted incorrectly.

Attachments
Example HTML reproducing the problem (2.50 KB, text/html) 2010-07-01 05:15 PDT, andy.shaw	no flags	Details
Propsoed patch (1.26 KB, patch) 2010-07-01 05:16 PDT, andy.shaw	no flags	Details Formatted Diff Diff
Proposed patch (trunk) (1.35 KB, patch) 2010-07-01 07:43 PDT, Andreas Kling	kling: review-	Details Formatted Diff Diff
Proposed patch v2 (5.84 KB, patch) 2010-07-12 08:01 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

andy.shaw

Comment 1 2010-07-01 05:16:05 PDT

Created attachment 60223 [details] Propsoed patch

Andreas Kling

Comment 2 2010-07-01 07:05:39 PDT

Confirmed on ToT + current 4.7. We only treat "text/plain" as UTF-16 text right now.

Andreas Kling

Comment 3 2010-07-01 07:43:09 PDT

Created attachment 60247 [details] Proposed patch (trunk)

Andreas Kling

Comment 4 2010-07-07 07:39:11 PDT

Comment on attachment 60247 [details] Proposed patch (trunk) r- after discussion with Simon. ClipboardQt needs more robustness in both getData() and setData() if we're to support arbitrary mimetypes. New patch coming in a bit.

Andreas Kling

Comment 5 2010-07-12 08:01:02 PDT

Created attachment 61231 [details] Proposed patch v2

WebKit Commit Bot

Comment 6 2010-07-12 08:18:11 PDT

Comment on attachment 61231 [details] Proposed patch v2 Clearing flags on attachment: 61231 Committed r63089: <http://trac.webkit.org/changeset/63089>

WebKit Commit Bot

Comment 7 2010-07-12 08:18:16 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.