Bug 41449

Summary:

[Qt] Autotest got missed in the handover of the QML WebView element

Product:

WebKit

Reporter:

Alan Alpert <alan.alpert>

Component:

Tools / Tests

Assignee:

Caio Marcelo de Oliveira Filho <cmarcelo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, commit-queue, jedrzej.nowacki, kling

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none
some code cleanup	none

Alan Alpert

Reported 2010-07-01 02:01:23 PDT

The autotests for this element are still in the Qt source tree (tests/auto/declarative) when they should be moved to be with the webkit tests (and then maintained with the WebView element).

Attachments
patch (45.69 KB, patch) 2011-04-15 17:02 PDT, Caio Marcelo de Oliveira Filho	no flags	Details Formatted Diff Diff
some code cleanup (1.69 KB, patch) 2011-04-19 12:53 PDT, Gopal Raghavan	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Caio Marcelo de Oliveira Filho

Comment 1 2011-04-15 17:02:54 PDT

Created attachment 89883 [details] patch

Andreas Kling

Comment 2 2011-04-16 21:16:04 PDT

Comment on attachment 89883 [details] patch rs=me

WebKit Commit Bot

Comment 3 2011-04-16 23:29:41 PDT

Comment on attachment 89883 [details] patch Clearing flags on attachment: 89883 Committed r84100: <http://trac.webkit.org/changeset/84100>

WebKit Commit Bot

Comment 4 2011-04-16 23:29:46 PDT

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 5 2011-04-17 00:43:01 PDT

The commit-queue encountered the following flaky tests while processing attachment 89883 [details]: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org) The commit-queue is continuing to process your patch.

Gopal Raghavan

Comment 6 2011-04-19 12:53:25 PDT

Created attachment 90240 [details] some code cleanup

Caio Marcelo de Oliveira Filho

Comment 7 2011-04-19 12:55:54 PDT

Gopal. I let that code there because the idea is to change the test so we do not depend on the private of QtDeclarative. See the QSKIP statement.

Eric Seidel (no email)

Comment 8 2011-04-20 13:37:16 PDT

Comment on attachment 90240 [details] some code cleanup Cleared review? from attachment 90240 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

Note You need to log in before you can comment on or make changes to this bug.