Bug 41438

Summary: Abstract 'a'-'z' checks into a function
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2010-06-30 16:54:33 PDT
Abstract 'a'-'z' checks into a function
Attachments
Patch (12.03 KB, patch)
2010-06-30 17:11 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (11.14 KB, patch)
2010-06-30 23:32 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-06-30 17:11:14 PDT
Created attachment 60171 [details] Patch
Adam Barth
Comment 2 2010-06-30 17:12:11 PDT
@Sam: I think you said there were some functions in a header somewhere that does this. I couldn't find it. Do you know where it is off-hand?
Eric Seidel (no email)
Comment 3 2010-06-30 17:15:12 PDT
wtf/ASCIICType.h
Eric Seidel (no email)
Comment 4 2010-06-30 17:21:39 PDT
Comment on attachment 60171 [details] Patch We should use the wtf functions.
Darin Adler
Comment 5 2010-06-30 18:48:45 PDT
Comment on attachment 60171 [details] Patch ASCIICType.h has all of these. You'd want to use isASCIIUpper and isASCIILower and toASCIILower.
Adam Barth
Comment 6 2010-06-30 23:32:33 PDT
Created attachment 60204 [details] Patch
Adam Barth
Comment 7 2010-06-30 23:33:59 PDT
> ASCIICType.h has all of these. You'd want to use isASCIIUpper and isASCIILower and toASCIILower. I didn't do toASCIILower because it's more complicated than what we're using (because we only call ours on ASCII upper chars), but I did the rest.
WebKit Commit Bot
Comment 8 2010-07-01 02:42:15 PDT
Comment on attachment 60204 [details] Patch Clearing flags on attachment: 60204 Committed r62242: <http://trac.webkit.org/changeset/62242>
WebKit Commit Bot
Comment 9 2010-07-01 02:42:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.