Bug 41430

Summary: Roll forward Chromium DEPS to r51287
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 41424    
Attachments:
Description Flags
Patch
dglazkov: review+, kbr: commit-queue-
Revised patch dglazkov: review+, kbr: commit-queue-

Kenneth Russell
Reported 2010-06-30 14:26:52 PDT
In order to stop linking against opengl32.lib in the Windows Chromium port ( https://bugs.webkit.org/show_bug.cgi?id=41424 ), it is necessary to roll forward the Chromium dependency in WebKit/chromium/DEPS to pick up dependent downstream changes.
Attachments
Patch (852 bytes, patch)
2010-06-30 14:29 PDT, Kenneth Russell 		dglazkov: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
Revised patch (852 bytes, patch)
2010-06-30 14:37 PDT, Kenneth Russell 		dglazkov: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-06-30 14:29:52 PDT
Created attachment 60154 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2010-06-30 14:30:35 PDT
Comment on attachment 60154 [details] Patch ok.
Kenneth Russell
Comment 3 2010-06-30 14:35:40 PDT
Actually, looking at the Chromium console, that is a bad revision to roll to. The next good looking revision is r51287. Will submit a revised patch.
Kenneth Russell
Comment 4 2010-06-30 14:37:09 PDT
Created attachment 60155 [details] Revised patch
Dimitri Glazkov (Google)
Comment 5 2010-06-30 14:38:01 PDT
Comment on attachment 60155 [details] Revised patch This number looks much better!
Kenneth Russell
Comment 6 2010-06-30 14:44:58 PDT
Committed r62206: <http://trac.webkit.org/changeset/62206>
Note You need to log in before you can comment on or make changes to this bug.