Bug 41409

Summary:

Safari pegs CPU and drops frames on http://neography.com/experiment/circles/solarsystem/ (CSS animations)

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin, simon.fraser

Priority:

Keywords:

InRadar, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

URL:

http://neography.com/experiment/circles/solarsystem/

Attachments:

Description	Flags
Patch	sam: review+

Description Adam Roben (:aroben) 2010-06-30 07:32:39 PDT

To reproduce:

1. Go to http://neography.com/experiment/circles/solarsystem/

The animation is quite choppy. If you look at Task Manager you'll see that Safari is pegging a CPU.

Comment 1 Adam Roben (:aroben) 2010-06-30 07:33:15 PDT

<rdar://problem/8146502>

Comment 2 Adam Roben (:aroben) 2010-06-30 07:35:24 PDT

On Mac, the performance is almost as bad if I turn off accelerated compositing.

It looks like this page isn't getting kicked into accelerated mode on Windows.

Comment 3 Simon Fraser (smfr) 2010-06-30 11:31:46 PDT

One issue here is that in AnimationBase, m_fallbackAnimating is always set to true when we don't use hardware animation, resulting in isAnimationRunning() returning false, which causes us to not use hardware.

Comment 4 Simon Fraser (smfr) 2010-06-30 11:42:22 PDT

Ah, I think the real issue is that on Windows, we still think we have accelerated opacity and transform animations.

Comment 5 Simon Fraser (smfr) 2010-07-15 16:46:55 PDT

Created attachment 61745 [details]
Patch

Comment 6 Simon Fraser (smfr) 2010-07-16 13:32:12 PDT

http://trac.webkit.org/changeset/63576