Bug 41409

Summary: Safari pegs CPU and drops frames on http://neography.com/experiment/circles/solarsystem/ (CSS animations)
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, simon.fraser
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
URL: http://neography.com/experiment/circles/solarsystem/
Attachments:
Description Flags
Patch sam: review+

Adam Roben (:aroben)
Reported 2010-06-30 07:32:39 PDT
To reproduce: 1. Go to http://neography.com/experiment/circles/solarsystem/ The animation is quite choppy. If you look at Task Manager you'll see that Safari is pegging a CPU.
Attachments
Patch (21.65 KB, patch)
2010-07-15 16:46 PDT, Simon Fraser (smfr) 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-06-30 07:33:15 PDT
<rdar://problem/8146502>
Adam Roben (:aroben)
Comment 2 2010-06-30 07:35:24 PDT
On Mac, the performance is almost as bad if I turn off accelerated compositing. It looks like this page isn't getting kicked into accelerated mode on Windows.
Simon Fraser (smfr)
Comment 3 2010-06-30 11:31:46 PDT
One issue here is that in AnimationBase, m_fallbackAnimating is always set to true when we don't use hardware animation, resulting in isAnimationRunning() returning false, which causes us to not use hardware.
Simon Fraser (smfr)
Comment 4 2010-06-30 11:42:22 PDT
Ah, I think the real issue is that on Windows, we still think we have accelerated opacity and transform animations.
Simon Fraser (smfr)
Comment 5 2010-07-15 16:46:55 PDT
Created attachment 61745 [details] Patch
Simon Fraser (smfr)
Comment 6 2010-07-16 13:32:12 PDT
http://trac.webkit.org/changeset/63576
Note You need to log in before you can comment on or make changes to this bug.