Bug 41407

Summary: [Qt] Make "disallow multiple calls to SetWindow" on windowed plugins a quirk
Product: WebKit Reporter: Andreas Kling <kling>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, reethu.j
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Bug Depends on:    
Bug Blocks: 40879    
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2010-06-30 06:43:30 PDT
Right now, we disallow more than one call to SetWindow on plugins since Flash used to crash if not running on top of Gtk+. Gtk+ unnecessarily copied this logic from PluginViewQt.cpp
Attachments
Proposed patch (4.66 KB, patch)
2010-06-30 06:53 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-06-30 06:53:53 PDT
Created attachment 60116 [details] Proposed patch
Kenneth Rohde Christiansen
Comment 2 2010-06-30 07:59:37 PDT
Comment on attachment 60116 [details] Proposed patch PluginViewQt should really have Linux in its name :-)
WebKit Commit Bot
Comment 3 2010-06-30 08:16:36 PDT
Comment on attachment 60116 [details] Proposed patch Clearing flags on attachment: 60116 Committed r62185: <http://trac.webkit.org/changeset/62185>
WebKit Commit Bot
Comment 4 2010-06-30 08:16:40 PDT
All reviewed patches have been landed. Closing bug.
Andreas Kling
Comment 5 2010-07-18 14:16:01 PDT
*** Bug 41037 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.