Bug 41406

Summary: [Qt, Gtk, Symbian] Mind the semantics of NPRect for windowed plugin clip rects
Product: WebKit Reporter: Andreas Kling <kling>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hausmann
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2010-06-30 05:44:06 PDT
There is code like this in PluginView{Qt,Gtk,Symbian}.cpp: m_npWindow.clipRect.left = m_clipRect.x(); m_npWindow.clipRect.top = m_clipRect.y(); m_npWindow.clipRect.right = m_clipRect.width(); m_npWindow.clipRect.bottom = m_clipRect.height(); (right vs width, bottom vs height) This causes incorrect clipping of windowed plugins.
Attachments
Proposed patch (3.72 KB, patch)
2010-06-30 05:49 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-06-30 05:49:06 PDT
Created attachment 60114 [details] Proposed patch
Simon Hausmann
Comment 2 2010-06-30 05:59:39 PDT
Can you explain on which website this breaks and/or what your test-case was?
Andreas Kling
Comment 3 2010-06-30 06:07:27 PDT
(In reply to comment #2) > Can you explain on which website this breaks and/or what your test-case was? I have no test-case, I'm actually working on bug 40879 but wanted to do this in a separate patch since it touches other platforms' files.
WebKit Commit Bot
Comment 4 2010-06-30 07:20:17 PDT
Comment on attachment 60114 [details] Proposed patch Clearing flags on attachment: 60114 Committed r62184: <http://trac.webkit.org/changeset/62184>
WebKit Commit Bot
Comment 5 2010-06-30 07:20:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.