Bug 41377

Summary:

Change the copy location for Chromium's Mac layout test plugin

Product:

WebKit

Reporter:

Stuart Morgan <stuartmorgan>

Component:

Tools / Tests

Assignee:

Stuart Morgan <stuartmorgan>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

tkent, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.6

Attachments:

Description	Flags
Switch copy destination	none

Stuart Morgan

Reported 2010-06-29 15:09:44 PDT

Chromium no longer needs to use an internal directory directory for test plugins, now that there's a --extra-plugin-dir argument, so we should start handling the layout plugin the same on the Mac as we do on the other platforms (which is to say, copy it to a plugins/ directory next to the application).

Attachments
Switch copy destination (1.18 KB, patch) 2010-06-29 16:18 PDT, Stuart Morgan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Stuart Morgan

Comment 1 2010-06-29 16:18:57 PDT

Created attachment 60070 [details] Switch copy destination

Kent Tamura

Comment 2 2010-06-29 22:21:37 PDT

Chromium DumpRenderTree has no --extra-plugin-dir option. So this patch won't work, right?

Stuart Morgan

Comment 3 2010-06-30 08:19:57 PDT

Doh, I wasn't thinking about this having a different launch infrastructure. So would the right fix be to add that flag to the command line in SetUpTestEnvironmentImpl?

Kent Tamura

Comment 4 2010-06-30 18:37:33 PDT

(In reply to comment #3) > So would the right fix be to add that flag to the command line in SetUpTestEnvironmentImpl? I think so.

Tony Chang

Comment 5 2010-10-19 14:22:56 PDT

Fixed with 47850. *** This bug has been marked as a duplicate of bug 47850 ***

Note You need to log in before you can comment on or make changes to this bug.