Bug 41342

Summary: Move PaintInfo/PaintPhase into their own headers, out of RenderObject
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: Layout and RenderingAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Initial patch krit: review+

Nikolas Zimmermann
Reported 2010-06-29 04:24:43 PDT
RenderObject is so cluttered, we could at least move PaintInfo / PaintPhase out of them, as a comment on top indicates.
Attachments
Initial patch (246.81 KB, patch)
2010-06-29 04:43 PDT, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-06-29 04:43:31 PDT
Created attachment 60008 [details] Initial patch Very mechnic, just search/replace and a move.
WebKit Review Bot
Comment 2 2010-06-29 04:46:10 PDT
Attachment 60008 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/rendering/RenderTheme.h:176: More than one command on the same line [whitespace/newline] [4] WebCore/rendering/InlineTextBox.cpp:360: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebCore/rendering/InlineFlowBox.cpp:691: _tx is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/rendering/InlineFlowBox.cpp:691: _ty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/rendering/InlineFlowBox.cpp:911: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 5 in 79 files If any of these errors are false positives, please file a bug against check-webkit-style.
Nikolas Zimmermann
Comment 3 2010-06-29 04:46:59 PDT
(In reply to comment #2) > Attachment 60008 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 > WebCore/rendering/RenderTheme.h:176: More than one command on the same line [whitespace/newline] [4] > WebCore/rendering/InlineTextBox.cpp:360: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] > WebCore/rendering/InlineFlowBox.cpp:691: _tx is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] > WebCore/rendering/InlineFlowBox.cpp:691: _ty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] > WebCore/rendering/InlineFlowBox.cpp:911: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] > Total errors found: 5 in 79 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. These issues aren't introduced by the patch, they've been there before, and I have no plan to change any code there, besides the renames. So please bear with those issues :-)
Dirk Schulze
Comment 4 2010-06-29 05:13:19 PDT
Comment on attachment 60008 [details] Initial patch r=me
Nikolas Zimmermann
Comment 5 2010-06-29 05:15:58 PDT
Landed in r62104.
Note You need to log in before you can comment on or make changes to this bug.