Summary: | Implement HTMLTreeBuilder::reconstructTheActiveFormattingElements | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, commit-queue, dbates, eric, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | OS X 10.5 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 41123 | ||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2010-06-28 17:05:53 PDT
Created attachment 59960 [details]
Patch
Comment on attachment 59960 [details]
Patch
I'd rather this patch had tests. If you wait 15 minutes, we'll have the harness landed...
WebCore/html/HTMLTreeBuilder.cpp:870
+ // Spec: Possible active formatting elements include:
I'd remove the word "spec" here.
WebCore/html/HTMLTreeBuilder.cpp:926
+ for (; previousEntryIndex > 0; previousEntryIndex--) {
Can we make this a while or a function that returns the answer? Also, predecrement!
WebCore/html/HTMLTreeBuilder.cpp:932
+ for (unsigned unopenEntryIndex = previousEntryIndex + 1; unopenEntryIndex < m_activeFormattingElements.size(); ++unopenEntryIndex) {
Can we assert that previousEntryIndex is not the last guy in the list?
WebCore/html/HTMLTreeBuilder.h:155
+ bool contains(Element* element)
We're going to need a cache here eventually.
WebCore/html/HTMLTreeBuilder.h:257
+ };
Blank line below this line.
Created attachment 59967 [details]
Patch
Comment on attachment 59967 [details]
Patch
WebCore/html/HTMLTreeBuilder.h:217
+ PassRefPtr<Element> createElement(AtomicHTMLToken&);
I would have put a blank line here to paragraph these.
Comment on attachment 59967 [details] Patch Clearing flags on attachment: 59967 Committed r62077: <http://trac.webkit.org/changeset/62077> All reviewed patches have been landed. Closing bug. This broke the Windows Release and Debug build bots. For completeness: Windows Release Stdio: <http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/1051/steps/compile-webkit/logs/stdio> Windows Debug Stdio: <http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/18218/steps/compile-webkit/logs/stdio> Landed attempt to fix the build in change-set 62080 <https://trac.webkit.org/changeset/62080>. http://trac.webkit.org/changeset/62080 might have broken Chromium Mac Release Created attachment 59981 [details]
Patch
Comment on attachment 59981 [details]
Patch
I don't love it. I'd rather have iterators, but ok.
Committed r62082: <http://trac.webkit.org/changeset/62082> |