Bug 41302

Summary: Drawing border-radius from path doesn't appear to always match up border edges correctly
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: CSSAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, simon.fraser, vikingjs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 58761    
Bug Blocks:    
Attachments:
Description Flags
Test case
none
Image explaining strategy for radius drawing none

Beth Dakin
Reported 2010-06-28 14:09:45 PDT
Created attachment 59937 [details] Test case http://trac.webkit.org/changeset/62035 introduced a new method of drawing border-radius using paths. Right now, this new code is only enabled for some platforms…if you want to know if your favorite platform has the new code path enabled, see if it has been added to #define HAVE_PATH_BASED_BORDER_RADIUS_DRAWING in RenderObject.h. I think there are some edge cases where we do not match up the radius edges as the W3C suggests. Attached is a test case demonstrating what I think is an incorrect rendering, and also a diagram demonstrating the correct rendering method.
Attachments
Test case (454 bytes, text/html)
2010-06-28 14:09 PDT, Beth Dakin
no flags
Image explaining strategy for radius drawing (49.03 KB, image/png)
2010-06-28 14:10 PDT, Beth Dakin
no flags
Beth Dakin
Comment 1 2010-06-28 14:10:48 PDT
Created attachment 59938 [details] Image explaining strategy for radius drawing
Jerry Seeger
Comment 2 2010-11-28 09:10:29 PST
Note that the radius strategy here does not conform to the CSS3 specification at http://www.w3.org/TR/css3-background/#corner-transitions Specifically, the spec says "The center of color and style transitions between adjoining borders is at the point on the curve that is at an angle that is proportional to the ratio of the border widths." I took a shot at interpreting just what the spec means at http://jerssoftwarehut.com/generalized-round-corner-diagram.xhtml
Simon Fraser (smfr)
Comment 3 2010-11-28 09:37:05 PST
I just read <http://jerssoftwarehut.com/generalized-round-corner-diagram.xhtml> (nice!). I'd encourage you to send feedback to the www-style mailing list highlighting the issues you saw in the spec.
Simon Fraser (smfr)
Comment 4 2011-04-19 11:47:03 PDT
Note You need to log in before you can comment on or make changes to this bug.