|Summary:||LayoutTests/canvas/philip/tests/security.drawImage.image.html Failed and skipped|
|Product:||WebKit||Reporter:||Chang Shu <cshu>|
|Component:||DOM||Assignee:||Chang Shu <cshu>|
|Severity:||Normal||CC:||cjerdonek, darin, dbates, eric, kenneth|
|Version:||528+ (Nightly build)|
|Bug Depends on:||42573, 49317|
Description Chang Shu 2010-06-28 06:47:20 PDT
The following security related canvas tests fail to pass and are put in the skipped list. LayoutTests/canvas/philip/tests/security.drawImage.image.html LayoutTests/canvas/philip/tests/security.drawImage.canvas.html
Comment 4 Chang Shu 2010-06-28 12:46:51 PDT
The script failed to patch the patch file but it seems to be a false-alarm to me. I don't understand why it tries to remove 'LayoutTests/canvas'. The log is here: fatal: not removing 'LayoutTests/canvas' recursively without -r Failed to git rm --force --ignore-unmatch LayoutTests/canvas. at /home/webkit/WebKit-qt-ews/WebKitTools/Scripts/svn-apply line 451.
Comment 5 Eric Seidel (no email) 2010-06-28 13:14:59 PDT
I suspect svn-apply is getting confused. https://trac.webkit.org/browser/trunk/WebKitTools/Scripts/VCSUtils.pm or https://trac.webkit.org/browser/trunk/WebKitTools/Scripts/svn-apply
Comment 6 Chang Shu 2010-06-29 15:03:41 PDT
Am I the only one who has this problem? Is there a work-around so I can have my patch reviewed? thanks!
Comment 8 Chang Shu 2010-07-19 09:06:55 PDT
The problem could be that in the patch, file tests.js has the wrong line-ending. I plan to commit a quick patch that does the following on this file: svn propset svn:eol-style native tests.js Does this sound ok?
Comment 13 Kenneth Rohde Christiansen 2010-07-19 13:12:32 PDT
Darin, what do you think about this change?
Comment 14 Darin Adler 2010-07-19 14:19:04 PDT
Comment on attachment 61983 [details] fix patch 1 Seems OK to move these. But why are we skipping all these tests on all platforms?
Comment 15 Chang Shu 2010-07-20 06:36:45 PDT
(In reply to comment #14) > (From update of attachment 61983 [details]) > Seems OK to move these. But why are we skipping all these tests on all platforms? This is the 1st part of the patch. I split it because I thought it could solve the problem that my patch failed to be applied (see all the pink buttons above). Actually, the complete patch is attached already. I can re-enable it and if you think it's good, I will commit it manually.
Comment 16 Chang Shu 2010-07-20 06:38:11 PDT
The 5th patch has the complete code change.