Bug 41235

Summary: uniformmatrix* should generate INVALID_VALUE with transpose = true
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, dglazkov, kbr, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch none

Description Zhenyao Mo 2010-06-25 16:52:36 PDT 
This is different between GL and GLES.
Comment 1 Zhenyao Mo 2010-06-28 10:28:59 PDT 
Created attachment 59908 [details]
patch
Comment 2 Kenneth Russell 2010-06-28 18:16:21 PDT 
Comment on attachment 59908 [details]
patch

Looks good. If there isn't already one, a bug should be filed about validating the size of the incoming Float32Arrays or (float*, int size) argument pairs. That validation should go pretty easily into the new validateUniformMatrixParameters helper.
Comment 3 Dimitri Glazkov (Google) 2010-06-29 14:58:28 PDT 
Comment on attachment 59908 [details]
patch

ok.
Comment 4 WebKit Commit Bot 2010-06-29 15:22:30 PDT 
Comment on attachment 59908 [details]
patch

Clearing flags on attachment: 59908

Committed r62150: <http://trac.webkit.org/changeset/62150>
Comment 5 WebKit Commit Bot 2010-06-29 15:22:35 PDT 
All reviewed patches have been landed.  Closing bug.