Summary: | uniformmatrix* should generate INVALID_VALUE with transpose = true | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zhenyao Mo <zmo> | ||||
Component: | WebGL | Assignee: | Zhenyao Mo <zmo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarrin, commit-queue, dglazkov, kbr, oliver | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Zhenyao Mo
2010-06-25 16:52:36 PDT
Created attachment 59908 [details]
patch
Comment on attachment 59908 [details]
patch
Looks good. If there isn't already one, a bug should be filed about validating the size of the incoming Float32Arrays or (float*, int size) argument pairs. That validation should go pretty easily into the new validateUniformMatrixParameters helper.
Comment on attachment 59908 [details]
patch
ok.
Comment on attachment 59908 [details] patch Clearing flags on attachment: 59908 Committed r62150: <http://trac.webkit.org/changeset/62150> All reviewed patches have been landed. Closing bug. |