| Summary: | Flesh out injected bundle code for WebKitTestRunner | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2010-06-25 14:21:59 PDT
Created attachment 59795 [details]
patch
Attachment 59795 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
Last 3072 characters of output:
rrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:54: InjectedBundlePage::_didStartProvisionalLoadForFrame is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:59: InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:64: InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:69: InjectedBundlePage::_didCommitLoadForFrame is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:74: InjectedBundlePage::_didFinishLoadForFrame is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:79: InjectedBundlePage::_didFailLoadWithErrorForFrame is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:84: InjectedBundlePage::_didReceiveTitleForFrame is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:89: InjectedBundlePage::_didClearWindowForFrame is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.h:32: Alphabetical sorting problem. [build/include_order] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:46: InjectedBundle::_didCreatePage is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:51: InjectedBundle::_willDestroyPage is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:56: InjectedBundle::_didRecieveMessage is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 27 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|