Bug 41204

Summary: Split up isSVGText() in isSVGText() / isSVGInlineText()
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Initial patch
none
Updated patch rwlbuis: review+

Nikolas Zimmermann
Reported 2010-06-25 02:43:09 PDT
We're currently using a dangerous way to differentiate between RenderSVGText / RenderSVGInlineText. We should better introduce a seperated isSVGInlineText(), to avoid confusion, and to be consistent with all other isFoo() functions. (isFoo() means can be casted to RenderFoo, everywhere else)
Attachments
Initial patch (4.98 KB, patch)
2010-06-25 02:45 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Updated patch (4.86 KB, patch)
2010-06-25 02:54 PDT, Nikolas Zimmermann 		rwlbuis: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-06-25 02:45:13 PDT
Created attachment 59748 [details] Initial patch
Nikolas Zimmermann
Comment 2 2010-06-25 02:54:40 PDT
Created attachment 59750 [details] Updated patch Uploaded the wrong patch :( The second one is correct.
Nikolas Zimmermann
Comment 3 2010-06-25 03:05:03 PDT
Landed in r61844.
WebKit Review Bot
Comment 4 2010-06-25 03:59:53 PDT
http://trac.webkit.org/changeset/61844 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/61843 http://trac.webkit.org/changeset/61844 http://trac.webkit.org/changeset/61845
Note You need to log in before you can comment on or make changes to this bug.