Bug 41202

Summary: Move decoding into DocumentParser to further simplify RawDataDocumentParser and DocumentWriter
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 41197    
Bug Blocks:    
Attachments:
Description Flags
work in progress
none
work in progress
none
Patch abarth: review+, abarth: commit-queue+

Eric Seidel (no email)
Reported 2010-06-25 02:25:24 PDT
Move decoding into DocumentParser to further simplify RawDataDocumentParser and DocumentWriter
Attachments
work in progress (18.77 KB, patch)
2010-06-25 02:29 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
work in progress (23.92 KB, patch)
2010-06-25 02:39 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (23.87 KB, patch)
2010-06-25 14:47 PDT, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-06-25 02:29:03 PDT
Created attachment 59746 [details] work in progress
Eric Seidel (no email)
Comment 2 2010-06-25 02:39:50 PDT
Created attachment 59747 [details] work in progress
Eric Seidel (no email)
Comment 3 2010-06-25 14:47:19 PDT
Created attachment 59799 [details] Patch
Adam Barth
Comment 4 2010-06-25 15:10:25 PDT
Comment on attachment 59799 [details] Patch It's slightly wonky that the raw data folks have a document writer that they ignore, but I guess that makes sense... We need a better name that DocumentWriter...
Eric Seidel (no email)
Comment 5 2010-06-25 15:13:48 PDT
I think the RawData folks are wrongly designed. They don't want to be parsers. They want some earlier method they can override to not be a parser. The RawData class is all about just sharing the broken code, not because it's the right design long-term. Shared broken code is better than copy/pasted broken code. :)
Eric Seidel (no email)
Comment 6 2010-06-25 16:47:19 PDT
Committed r61916: <http://trac.webkit.org/changeset/61916>
Note You need to log in before you can comment on or make changes to this bug.