Bug 41197

Summary: Split DocumentParser::write into separate append and insert calls
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, eric, tonyg, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41202    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing eric: commit-queue+

Eric Seidel (no email)
Reported 2010-06-25 00:44:51 PDT
Split DocumentParser::write into separate append and insert calls
Attachments
Patch (17.78 KB, patch)
2010-06-25 01:24 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (21.32 KB, patch)
2010-06-25 02:51 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (21.34 KB, patch)
2010-06-25 13:43 PDT, Eric Seidel (no email) 		eric: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-06-25 01:24:38 PDT
Created attachment 59742 [details] Patch
Early Warning System Bot
Comment 2 2010-06-25 01:31:37 PDT
Attachment 59742 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/3340754
Eric Seidel (no email)
Comment 3 2010-06-25 02:51:34 PDT
Created attachment 59749 [details] Patch
Early Warning System Bot
Comment 4 2010-06-25 03:08:02 PDT
Attachment 59749 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/3316707
Adam Barth
Comment 5 2010-06-25 09:46:22 PDT
Comment on attachment 59749 [details] Patch I wonder if we should have another method for the "I'm giving you all the data at once" use case. It seems a bit odd to call "insert" for that use just because you want it to be synchronous. There are other side effects too, like not using the pre-load scanner. Do we want to use the preload scanner for FTP directory listings? (Probably not for XMLHttpRequest.) Maybe we really should have an options argument? It's unclear to me what the most elegant solution is. WebCore/html/HTMLDocumentParser.cpp:216 + void HTMLDocumentParser::insert(const SegmentedString& source) Has tony's patch to exclude line numbers not landed? That should be here too.
Eric Seidel (no email)
Comment 6 2010-06-25 11:28:48 PDT
Tony's line number patch has not been landed yet, no. Bug 41060.
Tony Gentilcore
Comment 7 2010-06-25 11:33:50 PDT
(In reply to comment #6) > Tony's line number patch has not been landed yet, no. Bug 41060. #19 in the queue :-(
Adam Barth
Comment 8 2010-06-25 11:37:36 PDT
> #19 in the queue :-( We made the commit-queue more agressive last night. It should empty out tonight. It reached a high water mark of 50-some patch. O_o
Eric Seidel (no email)
Comment 9 2010-06-25 13:43:55 PDT
Created attachment 59791 [details] Patch for landing
Eric Seidel (no email)
Comment 10 2010-06-25 13:44:13 PDT
Comment on attachment 59791 [details] Patch for landing Mark r? so the Qt EWS runs this.
Eric Seidel (no email)
Comment 11 2010-06-25 13:58:09 PDT
Comment on attachment 59791 [details] Patch for landing Qt loves me again!
Eric Seidel (no email)
Comment 12 2010-06-25 14:37:28 PDT
Committed r61904: <http://trac.webkit.org/changeset/61904>
WebKit Review Bot
Comment 13 2010-06-25 14:55:03 PDT
http://trac.webkit.org/changeset/61904 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/61904 http://trac.webkit.org/changeset/61903
Note You need to log in before you can comment on or make changes to this bug.