| Summary: | Split DocumentParser::write into separate append and insert calls | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||
| Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, darin, eric, tonyg, webkit-ews, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 41202 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Eric Seidel (no email)
2010-06-25 00:44:51 PDT
Created attachment 59742 [details]
Patch
Attachment 59742 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/3340754 Created attachment 59749 [details]
Patch
Attachment 59749 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/3316707 Comment on attachment 59749 [details]
Patch
I wonder if we should have another method for the "I'm giving you all the data at once" use case. It seems a bit odd to call "insert" for that use just because you want it to be synchronous. There are other side effects too, like not using the pre-load scanner. Do we want to use the preload scanner for FTP directory listings? (Probably not for XMLHttpRequest.) Maybe we really should have an options argument? It's unclear to me what the most elegant solution is.
WebCore/html/HTMLDocumentParser.cpp:216
+ void HTMLDocumentParser::insert(const SegmentedString& source)
Has tony's patch to exclude line numbers not landed? That should be here too.
Tony's line number patch has not been landed yet, no. Bug 41060. (In reply to comment #6) > Tony's line number patch has not been landed yet, no. Bug 41060. #19 in the queue :-( > #19 in the queue :-(
We made the commit-queue more agressive last night. It should empty out tonight. It reached a high water mark of 50-some patch. O_o
Created attachment 59791 [details]
Patch for landing
Comment on attachment 59791 [details]
Patch for landing
Mark r? so the Qt EWS runs this.
Comment on attachment 59791 [details]
Patch for landing
Qt loves me again!
Committed r61904: <http://trac.webkit.org/changeset/61904> http://trac.webkit.org/changeset/61904 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/61904 http://trac.webkit.org/changeset/61903 |