Bug 41145

Summary: Add plugin accessors to WebPluginContainer.
Product: WebKit Reporter: Bernhard Bauer <bauerb>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Add plugin accessor to WebPluginContainer.
none
Add plugin accessor to WebPluginContainer.
fishd: review-
Add plugin accessor to WebPluginContainer. none

Bernhard Bauer
Reported 2010-06-24 04:12:23 PDT
In order to swap out a plugin placeholder for a real plugin when doing click-to-load, WebPluginContainer needs accessors.
Attachments
Add plugin accessor to WebPluginContainer. (1.73 KB, patch)
2010-06-24 04:16 PDT, Bernhard Bauer 		no flags
DetailsFormatted DiffDiff
Add plugin accessor to WebPluginContainer. (1.72 KB, patch)
2010-06-24 10:20 PDT, Bernhard Bauer 		fishd: review-
DetailsFormatted DiffDiff
Add plugin accessor to WebPluginContainer. (2.27 KB, patch)
2010-06-25 04:41 PDT, Bernhard Bauer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Bernhard Bauer
Comment 1 2010-06-24 04:16:47 PDT
Created attachment 59630 [details] Add plugin accessor to WebPluginContainer.
David Levin
Comment 2 2010-06-24 10:10:48 PDT
Comment on attachment 59630 [details] Add plugin accessor to WebPluginContainer. fyi WebKit/chromium/public/WebPluginContainer.h:82 + virtual void setPlugin(WebPlugin* plugin) = 0; WebKit typically doesn't include parameter names in declarations when those names add no new information, so omit "plugin".
Bernhard Bauer
Comment 3 2010-06-24 10:20:58 PDT
Created attachment 59668 [details] Add plugin accessor to WebPluginContainer. Removed parameter "plugin" from setPlugin().
Darin Fisher (:fishd, Google)
Comment 4 2010-06-24 11:16:01 PDT
Comment on attachment 59668 [details] Add plugin accessor to WebPluginContainer. WebKit/chromium/src/WebPluginContainerImpl.h:111 + void setPlugin(WebPlugin* plugin) { m_webPlugin = plugin; } nit: please move these into the "WebPluginContainer methods" section.
Bernhard Bauer
Comment 5 2010-06-25 04:41:29 PDT
Created attachment 59758 [details] Add plugin accessor to WebPluginContainer. Moved accessors to WebPluginContainer methods section.
WebKit Commit Bot
Comment 6 2010-06-25 22:51:12 PDT
Comment on attachment 59758 [details] Add plugin accessor to WebPluginContainer. Clearing flags on attachment: 59758 Committed r61942: <http://trac.webkit.org/changeset/61942>
WebKit Commit Bot
Comment 7 2010-06-25 22:51:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.