Add plugin accessors to WebPluginContainer.

• Component: New Bugs
• Status: RESOLVED FIXED

[Bernhard Bauer]

In order to swap out a plugin placeholder for a real plugin when doing click-to-load, WebPluginContainer needs accessors.

[Bernhard Bauer]

Created attachment 59630 [details]
Add plugin accessor to WebPluginContainer.

[David Levin]

Comment on attachment 59630 [details]
Add plugin accessor to WebPluginContainer.

fyi

WebKit/chromium/public/WebPluginContainer.h:82
 +      virtual void setPlugin(WebPlugin* plugin) = 0;
WebKit typically doesn't include parameter names in declarations when those names add no new information, so omit "plugin".

[Bernhard Bauer]

Created attachment 59668 [details]
Add plugin accessor to WebPluginContainer.

Removed parameter "plugin" from setPlugin().

[Darin Fisher (:fishd, Google)]

Comment on attachment 59668 [details]
Add plugin accessor to WebPluginContainer.



WebKit/chromium/src/WebPluginContainerImpl.h:111
 +      void setPlugin(WebPlugin* plugin) { m_webPlugin = plugin; }
nit: please move these into the "WebPluginContainer methods" section.

[Bernhard Bauer]

Created attachment 59758 [details]
Add plugin accessor to WebPluginContainer.

Moved accessors to WebPluginContainer methods section.

[WebKit Commit Bot]

Comment on attachment 59758 [details]
Add plugin accessor to WebPluginContainer.

Clearing flags on attachment: 59758

Committed r61942: <http://trac.webkit.org/changeset/61942>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.