Bug 41136

Summary: Add RawDataDocumentParser to get rid of a bunch of copy/paste code in DocumentParser subclasses
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, tonyg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 41117    
Bug Blocks: 41141    
Attachments:
Description Flags
Patch abarth: review+, eric: commit-queue+

Eric Seidel (no email)
Reported 2010-06-24 00:35:34 PDT
Add RawDataDocumentParser to get rid of a bunch of copy/paste code in DocumentParser subclasses
Attachments
Patch (19.55 KB, patch)
2010-06-24 00:42 PDT, Eric Seidel (no email) 		abarth: review+
eric: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-06-24 00:42:46 PDT
Created attachment 59622 [details] Patch
Adam Barth
Comment 2 2010-06-24 14:43:38 PDT
Comment on attachment 59622 [details] Patch This patch appears to be almost entirely minus lines. WebCore/dom/RawDataDocumentParser.h:57 + ASSERT_NOT_REACHED(); This used to be notImplemented, right?
Eric Seidel (no email)
Comment 3 2010-06-24 14:45:55 PDT
(In reply to comment #2) > (From update of attachment 59622 [details]) > This patch appears to be almost entirely minus lines. Yup. :) > WebCore/dom/RawDataDocumentParser.h:57 > + ASSERT_NOT_REACHED(); > This used to be notImplemented, right? Yup. And remove the method entirely in the next patch. We have no test case which hits that ASSERT, and its unclear if such a case is even possible.
Eric Seidel (no email)
Comment 4 2010-06-24 15:03:47 PDT
Committed r61789: <http://trac.webkit.org/changeset/61789>
Note You need to log in before you can comment on or make changes to this bug.