Bug 41119

Summary:

Code generator now generates jsString instead of toJS for callbacks

Product:

WebKit

Reporter:

Sterling Swigart <sswigart>

Component:

Images

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dumi, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

39905

Attachments:

Description	Flags
toJS -> jsString	none
Fixes callback parameter generation	none

Sterling Swigart

Reported 2010-06-23 18:04:34 PDT

Created attachment 59591 [details] toJS -> jsString Callback code generation before generated toJS for String parameters, which cannot convert a String to DOMString. The generated file would not build.

Attachments
toJS -> jsString (1.46 KB, patch) 2010-06-23 18:04 PDT, Sterling Swigart	no flags	Details Formatted Diff Diff
Fixes callback parameter generation (2.27 KB, patch) 2010-06-24 10:35 PDT, Sterling Swigart	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dumitru Daniliuc

Comment 1 2010-06-23 18:12:05 PDT

Comment on attachment 59591 [details] toJS -> jsString LGTM, thanks for noticing the bug and fixing it! Will cq+ once all bots go green.

Sterling Swigart

Comment 2 2010-06-24 10:35:28 PDT

Created attachment 59672 [details] Fixes callback parameter generation

WebKit Commit Bot

Comment 3 2010-06-25 20:40:19 PDT

Comment on attachment 59672 [details] Fixes callback parameter generation Clearing flags on attachment: 59672 Committed r61937: <http://trac.webkit.org/changeset/61937>

WebKit Commit Bot

Comment 4 2010-06-25 20:40:23 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.