Summary: | Code generator now generates jsString instead of toJS for callbacks | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sterling Swigart <sswigart> | ||||||
Component: | Images | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dumi, levin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 39905 | ||||||||
Attachments: |
|
Comment on attachment 59591 [details]
toJS -> jsString
LGTM, thanks for noticing the bug and fixing it! Will cq+ once all bots go green.
Created attachment 59672 [details]
Fixes callback parameter generation
Comment on attachment 59672 [details] Fixes callback parameter generation Clearing flags on attachment: 59672 Committed r61937: <http://trac.webkit.org/changeset/61937> All reviewed patches have been landed. Closing bug. |
Created attachment 59591 [details] toJS -> jsString Callback code generation before generated toJS for String parameters, which cannot convert a String to DOMString. The generated file would not build.