Bug 41088

Summary:

[Qt] support dumpChildFrameScrollPositions

Product:

WebKit

Reporter:

Robert Hogan <robert>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

41261

Bug Blocks:

Attachments:

Description	Flags
Patch	kenneth: review+

Robert Hogan

Reported 2010-06-23 11:36:30 PDT

support dumpChildFrameScrollPositions

Attachments
Patch (10.52 KB, patch) 2010-06-23 11:46 PDT, Robert Hogan	kenneth: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Robert Hogan

Comment 1 2010-06-23 11:46:17 PDT

Created attachment 59546 [details] Patch

Kenneth Rohde Christiansen

Comment 2 2010-06-28 06:46:41 PDT

Comment on attachment 59546 [details] Patch WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:678 + QList<QWebFrame *> children = frame->childFrames(); No space needed before * WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:691 + QWebFrame* parent = qobject_cast<QWebFrame *>(frame->parent()); Neither here

Robert Hogan

Comment 3 2010-07-03 03:01:15 PDT

Committed r62444: <http://trac.webkit.org/changeset/62444>

WebKit Review Bot

Comment 4 2010-07-03 03:20:08 PDT

http://trac.webkit.org/changeset/62444 might have broken Qt Linux Release

Robert Hogan

Comment 5 2010-07-03 03:59:24 PDT

(In reply to comment #4) > http://trac.webkit.org/changeset/62444 might have broken Qt Linux Release Just needed to update some test results to reflect support for the feature. This was done in r62445.

Note You need to log in before you can comment on or make changes to this bug.