Bug 41083

Summary:

fast/parser/broken-comments-vs-parsing mode no longer tests for what it used to test

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed fix	eric: review+

Description Alexey Proskuryakov 2010-06-23 11:05:12 PDT

The comment should be treated as a comment, so hiding it inside <title> isn't good.

Comment 1 Alexey Proskuryakov 2010-06-23 11:21:00 PDT

Created attachment 59537 [details]
proposed fix

Comment 2 Eric Seidel (no email) 2010-06-23 11:53:54 PDT

Comment on attachment 59537 [details]
proposed fix

So the test used to fail to go into quirks mode because of the comment?  Are we sure that this placement of the comment will cause the same effect?

Comment 3 Alexey Proskuryakov 2010-06-23 12:13:37 PDT

Committed <http://trac.webkit.org/changeset/61704>.

> So the test used to fail to go into quirks mode because of the comment?

Actually, vice versa - there is no DOCTYPE, so the test shouldn't be in strict mode. Bug 8626 was about strict mode being entered in error.

> Are we sure that this placement of the comment will cause the same effect?

It was a long time ago, but my recollection about that bug is that yes, the modified test should still cover it.