Summary: | [Qt] tst_QWebFrame::callQtInvokable() fails | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jędrzej Nowacki <jedrzej.nowacki> | ||||
Component: | WebKit Qt | Assignee: | QtWebKit Unassigned <webkit-qt-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hausmann, kling, laszlo.gombos, robert | ||||
Priority: | P1 | Keywords: | Qt, QtTriaged, Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 38654 | ||||||
Attachments: |
|
Description
Jędrzej Nowacki
2010-06-23 06:51:22 PDT
Regression caused by <http://trac.webkit.org/changeset/61478> (the change to WebCore/bridge/qt/qt_runtime.cpp) I don't see why getPropertyNames() would crash in that scenario, and cannot reproduce with the two mentioned tests (world-reuse.html and didClearWindowObject.html) Created attachment 61925 [details] Proposed patch Proposed partial revert of <http://trac.webkit.org/changeset/61478> (In reply to comment #2) > Created an attachment (id=61925) [details] > Proposed patch > > Proposed partial revert of <http://trac.webkit.org/changeset/61478> Note to self: make sure I pass the unit tests in future too. If you can't recreate that's fair enough - if I can still recreate when you revert I'll create a new bug for it. The two tests in question are already skipped. Comment on attachment 61925 [details] Proposed patch Clearing flags on attachment: 61925 Committed r64011: <http://trac.webkit.org/changeset/64011> All reviewed patches have been landed. Closing bug. |