Bug 41047
| Summary: | Unify three methods to decide whether a renderer should be created | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ddkilzer, hyatt, mitz |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Nikolas Zimmermann
We currently have three code paths doing decisions on whether a renderer should be created/destroyed:
- Node::rendererIsNeeded(RenderStyle*) - decide whether a Node need a renderer based on RenderStyle information (display() != NONE, etc.)
- Node::childShouldCreateRenderer(Node*) - decide whether a children of a certain element should get a renderer
- RenderObject::isChildAllowed() - checks whether a new renderer can be appended, if not the renderer is destroyed again (see createRendererIfNeeded())
These code paths should ideally be unified.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |